use-assert-equal

Collection: fixit-extra Autofix: Yes Python: Any

Finds incorrect use of assertTrue when the intention is to compare two values. These calls are replaced with assertEqual. Comparisons with True, False and None are replaced with one-argument calls to assertTrue, assertFalse and assertIsNone.

Message

“assertTrue” does not compare its arguments, use “assertEqual” or other appropriate functions.

Valid examples

self.assertTrue(a == b)

self.assertTrue(data.is_valid(), "is_valid() method")

self.assertTrue(validate(len(obj.getName(type=SHORT))))

self.assertTrue(condition, message_string)

Invalid examples

self.assertTrue(a, 3)

Suggested fix

self.assertEqual(a, 3)

self.assertTrue(hash(s[:4]), 0x1234)

Suggested fix

self.assertEqual(hash(s[:4]), 0x1234)

self.assertTrue(list, [1, 3])

Suggested fix

self.assertEqual(list, [1, 3])

Show more

self.assertTrue(optional, None)

Suggested fix

self.assertIsNone(optional)

self.assertTrue(b == a, True)

Suggested fix

self.assertTrue(b == a)

self.assertTrue(b == a, False)

Suggested fix

self.assertFalse(b == a)